GRMrGecko/midi-harbor
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(release): let git read the tree mounted into the release container

Browse source 
- `make release` failed at once with "current folder is not a git repository". Docker Desktop showed the mounted tree's top directory as owned by root while the build runs as the calling user, so git refused the repository as dubiously owned and GoReleaser could not read the tag.
- The release and snapshot containers now name `/src` as a `safe.directory` through git's `GIT_CONFIG_*` environment variables, which needs no configuration file in the image or the tree.
This commit is contained in:
James Coleman 2026-10-04 08:46:46 -05:00
parent 57fe7ff53a
commit bb89799df1
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Makefile
View file

@ -20,6 +20,8 @@ BUILD_ID := $(shell uuidgen | tr '[:upper:]' '[:lower:]')
# the full and headless builds of one target share. Cargo still builds each in parallel. # the full and headless builds of one target share. Cargo still builds each in parallel.
# Docker creates a missing volume owned by root, so the volume is handed to the build's user # Docker creates a missing volume owned by root, so the volume is handed to the build's user
# first; otherwise a release after make clean cannot write to target/. # first; otherwise a release after make clean cannot write to target/.
# Docker Desktop can show the mounted tree's top directory as root's, which git refuses as
# "dubious ownership" and GoReleaser reports as "not a git repository", so the tree is named safe.
GORELEASER = mkdir -p $(CARGO_CACHE) && docker run --rm \ GORELEASER = mkdir -p $(CARGO_CACHE) && docker run --rm \
--user 0:0 \ --user 0:0 \
--entrypoint chown \ --entrypoint chown \
@ -29,6 +31,9 @@ GORELEASER = mkdir -p $(CARGO_CACHE) && docker run --rm \
--user $(shell id -u):$(shell id -g) \ --user $(shell id -u):$(shell id -g) \
-e CARGO_HOME=/cargo-home \ -e CARGO_HOME=/cargo-home \
-e HOME=/tmp \ -e HOME=/tmp \
-e GIT_CONFIG_COUNT=1 \
-e GIT_CONFIG_KEY_0=safe.directory \
-e GIT_CONFIG_VALUE_0=/src \
-e MIDI_HARBOR_MAINTAINER="$(MIDI_HARBOR_MAINTAINER)" \ -e MIDI_HARBOR_MAINTAINER="$(MIDI_HARBOR_MAINTAINER)" \
-e MIDI_HARBOR_VERSION="$(VERSION)" \ -e MIDI_HARBOR_VERSION="$(VERSION)" \
-e MIDI_HARBOR_BUILD_ID="$(BUILD_ID)" \ -e MIDI_HARBOR_BUILD_ID="$(BUILD_ID)" \