From 2c27526ab566b4a8041062f2095f7e71a203104a Mon Sep 17 00:00:00 2001 From: Artur Petrov Date: Mon, 29 Sep 2014 03:45:37 +0400 Subject: [PATCH] Improve string casting of revision info values Some revision payloads contain git hashes in place of revision number for built-in components (webkit, v8). We should use universal -description instead of NSNumber's -stringValue. See revision #278870 for example. --- Classes/MGMController.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Classes/MGMController.m b/Classes/MGMController.m index f4167b9..ef9876c 100644 --- a/Classes/MGMController.m +++ b/Classes/MGMController.m @@ -382,12 +382,12 @@ NSString * const MGMUBCancel = @"Cancel"; } - (void)revisionDidFinish:(MGMURLBasicHandler *)theHandler { NSDictionary *revisionInfo = [[theHandler data] parseJSON]; - NSString *webkit = [[revisionInfo objectForKey:@"webkit_revision"] stringValue]; + NSString *webkit = [NSString stringWithFormat:@"%@", [revisionInfo objectForKey:@"webkit_revision"]]; if (webkit!=nil) [webKitBuildField setStringValue:webkit]; else [webKitBuildField setStringValue:@"0"]; - NSString *v8 = [[revisionInfo objectForKey:@"v8_revision"] stringValue]; + NSString *v8 = [NSString stringWithFormat:@"%@", [revisionInfo objectForKey:@"v8_revision"]]; if (v8!=nil) [v8BuildField setStringValue:v8]; else